smithproject.org

Consider the following code, which works in CF5:
Code:

<cffile action="UPLOAD" filefield="something"
     destination="somewhere" nameconflict="MAKEUNIQUE"
     accept="image/gif, image/jpeg, image/png"
     mode="644">

Under Smith, this will work with image/gif, because it is the first item in the list. However, image/jpeg, etc. will not work because Smith is not really looking for "image/jpeg" but for " image/jpeg" (notice the space) in the content type. Ditto image/png and anything else after that.

Changing accept to "image/gif,image/jpeg,image/png" will fix it, but this is probably not the intended behavior.

Cars, thanks for the notice, it will be fixed!

btw. note that recently (after smith-1.3b6 release), the file upload in SVN has been rewritten using apache commons file upload. have you tested this with the latest code from SVN, or with smith-1.3b6 ?

orcus

Tested, fixed, added to SVN, will be included in the next build.

The problem was that whitespace was not ignored in accept...
In FileTagImpl.upload(), line:

Code:

    if (SmithList.ListFindNoCase(accept, mime) == 0) {

replaced with:

Code:

    if (SmithList.ListFindNoCase(accept.replaceAll("[ \t]", ""), mime) == 0) {